-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump nix from 0.27.1 to 0.29.0 #4793
base: develop
Are you sure you want to change the base?
Conversation
Bumps [nix](https://github.com/nix-rust/nix) from 0.27.1 to 0.29.0. - [Changelog](https://github.com/nix-rust/nix/blob/master/CHANGELOG.md) - [Commits](nix-rust/nix@v0.27.1...v0.29.0) --- updated-dependencies: - dependency-name: nix dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Includes upgrading nymvisor to latest nix crate, which involves some changes with respect to file locks. @jstuczyn |
libc_code: err, | ||
}); | ||
} | ||
let _lock = match Flock::lock(lock_file, FlockArg::LockExclusiveNonblock) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to the changes to flock, I'd feel better if we tested it before merging. because I'm not sure if Flock::drop()
will work since it will attempt to unlock the lock. However, by the time it goes out of scope, the file would have been manually removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes always good to be cautious, let's park this for now until we have chance to verify it actually working :)
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Bumps nix from 0.27.1 to 0.29.0.
Changelog
Sourced from nix's changelog.
... (truncated)
Commits
1dad4d8
chore: prepare for 0.29.0f743197
fix ControlMessageOwned::UdpGroSegments UDP packets processing type. (#2406)208b80b
recvmsg: Check if CMSG buffer was too small and return an error (#2413)ecd12a9
test: remove test of inode count in test_statfs.rs (#2414)663506a
fix: only closefanotify
events with a valid fd (#2399)1604723
revert: impl From<sigaction> for SigAction (#2410)ec4beb5
docs: correct limit value of FAN_UNLIMITED_QUEUE and FAN_UNLIMITED_MARKS[skip...84c0444
chore: bump libc to 0.2.155 (#2409)c5af4ad
Add Flock::relock (#2407)e7acaff
Enable O_DSYNC on FreeBSD with fcntl and aio_fsync (#2404)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)This change is