Use secure DNS for websocket connection establishment #5386
+127
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
reviewed
Jan 23, 2025
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
octol
reviewed
Jan 24, 2025
jstuczyn
reviewed
Jan 24, 2025
jmwample
commented
Jan 27, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @aniampio, @jstuczyn, and @octol)
jmwample
commented
Jan 27, 2025
octol
approved these changes
Feb 4, 2025
|
Wasm is intentionally and explicitly (via compiler directives) excluded from these changes. There is no change to the wasm behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the websocket connection establishment (using
tokio_tungstenite) to use a custom DNS resolver that tries DoH and DoT.instead of relying on the
tokio_tungsteniteto open thetokio::net::TcpStream(which it does here) which would kick in the default network resolver we do the resolution and open theTcpStreamourselves before handing off to the websocket libary,This change is