[Fixed] Fixed a regression that would cause Twitter and Facebook imag…

…es to not show up
nystudio107 · Sep 6, 2016 · 4e2cb11 · 4e2cb11
1 parent e3a01e3
commit 4e2cb11
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -56,6 +56,11 @@ Some things to do, and ideas for potential features:
 
 ## Changelog
 
+### 1.1.35 -- 2016.09.06
+
+* [Fixed] Fixed a regression that would cause Twitter and Facebook images to not show up
+* [Improved] Updated the README.md
+
 ### 1.1.34 -- 2016.09.05
 
 * [Added] Added the ability to set separate images for Twitter Cards and Facebook OpenGraph images

diff --git a/SeomaticPlugin.php b/SeomaticPlugin.php
@@ -26,7 +26,7 @@ public function getReleaseFeedUrl()
 
     public function getVersion()
     {
-        return '1.1.34';
+        return '1.1.35';
     }
 
     public function getSchemaVersion()

diff --git a/releases.json b/releases.json
@@ -1,4 +1,13 @@
 [
+    {
+        "version": "1.1.35",
+        "downloadUrl": "https://github.com/nystudio107/seomatic/archive/master.zip",
+        "date": "2016-09-06T11:00:00-11:00",
+        "notes": [
+            "[Fixed] Fixed a regression that would cause Twitter and Facebook images to not show up",
+            "[Improved] Updated the README.md"
+        ]
+    },
     {
         "version": "1.1.34",
         "downloadUrl": "https://github.com/nystudio107/seomatic/archive/master.zip",

diff --git a/services/SeomaticService.php b/services/SeomaticService.php
@@ -815,7 +815,7 @@ public function setSocialForMeta(&$meta, $siteMeta, $social, $helper, $identity,
                 $imgId = 0;
                 if (isset($meta['seoImageId']))
                     $imgId = $meta['seoImageId'];
-                if (isset($meta['seoTwitterImageId']))
+                if (isset($meta['seoTwitterImageId']) && $meta['seoTwitterImageId'] != 0)
                     $imgId = $meta['seoTwitterImageId'];
                 if ($imgId)
                 {
@@ -858,7 +858,7 @@ public function setSocialForMeta(&$meta, $siteMeta, $social, $helper, $identity,
             $imgId = 0;
             if (isset($meta['seoImageId']))
                 $imgId = $meta['seoImageId'];
-            if (isset($meta['seoFacebookImageId']))
+            if (isset($meta['seoFacebookImageId']) && $meta['seoFacebookImageId'] != 0)
                 $imgId = $meta['seoFacebookImageId'];
             if ($imgId)
             {