Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

prevent errors on Dashboard by rendering field only in single-entry context #24

Merged
merged 1 commit into from
Feb 10, 2016
Merged

Conversation

intoeetive
Copy link
Contributor

No description provided.

@khalwat
Copy link
Collaborator

khalwat commented Feb 10, 2016

How are errors generated? Trying to replicate it

@intoeetive
Copy link
Contributor Author

Without this fix, whenever I access Dashboard I get Trying to get property of non-object referencing this line in Seomatic_MetaFieldType.php
$fieldData = array('title' => $this->element->content['title']);

@intoeetive
Copy link
Contributor Author

Separate, but related issue: with latest release, when creating new field I get
Variable "element" does not exist in /craft/plugins/seomatic/templates/field_settings.html(3)

@khalwat
Copy link
Collaborator

khalwat commented Feb 10, 2016

There is no field_settings.html in the current release... is there a chance you could have merged the current release with the previous release? Please see here:

#21

@intoeetive
Copy link
Contributor Author

You-re right, the template error is because I kept old template files.

However the first Dashboard issue is still there, as it's not template-related

@khalwat
Copy link
Collaborator

khalwat commented Feb 10, 2016

Got it, thanks, merging!

khalwat added a commit that referenced this pull request Feb 10, 2016
prevent errors on Dashboard by rendering field only in single-entry context
@khalwat khalwat merged commit df24d48 into nystudio107:develop Feb 10, 2016
@OezlemYi
Copy link

Wondering, because I get still errors..
Maybe a few infos: I use plesk server with PHP 7.1.12. The error is showing when I want to analysis the SEOmetrics Content.
But the error is also showing with PHP 5.6. Any ideas?

bildschirmfoto 2017-12-12 um 16 00 12

bildschirmfoto 2017-12-12 um 16 00 17

bildschirmfoto 2017-12-12 um 16 00 24

@khalwat
Copy link
Collaborator

khalwat commented Dec 12, 2017

So that's an error because it can't find a <title> tag on the page. I should probably safeguard against this, but if you're using SEOmatic, I'm not sure how you could not have a <title> tag on there?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants