Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive Ord and Eq for Epoch #133

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

mkolopanis
Copy link
Contributor

Derives Ord and Eq for epoch.
I also added a small test to check expected orderings between two epochs.

@ChristopherRabotin
Copy link
Member

Looks good, thanks!
For the std cmp ordering in the test, you can use core::cmp::ordering if the std feature is not available. That change would allow the tests to check the equality even without std.

@mkolopanis
Copy link
Contributor Author

Thanks for the tip, always forget about core counterparts

@ChristopherRabotin ChristopherRabotin merged commit 07168d9 into nyx-space:master Aug 2, 2022
@ChristopherRabotin
Copy link
Member

Thanks for the PR! I'll release this with version 3.3 this weekend if that works for you too.

@mkolopanis mkolopanis deleted the epoch_derive_ord branch August 2, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants