-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conversion to Gregorian #303
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5bc584a
Pick up #261
ChristopherRabotin c253379
There is a remaining bug in the formatting of old UTC dates
ChristopherRabotin ba821ac
Merge branch 'master' into bug/261-jde_utc_days-error
ChristopherRabotin 9dca494
Rewrote compute_gregorian. It works for the edge cases but not the no…
ChristopherRabotin bd2b691
Simply the function quite a bit, but some tests still don't pass
ChristopherRabotin b1ddfe2
Still working on Gregorian logic on leap years
ChristopherRabotin ece13e9
Durations print with "day" in singular or plural
ChristopherRabotin d5b9ebf
Add CUMULATIVE_DAYS_FOR_MONTH_LEAP_YEARS constant
ChristopherRabotin 938204b
Removed edges cases in Gregorian computation for very negative dates
ChristopherRabotin 28b91fb
Trying to fix the to/from Gregorian
ChristopherRabotin 878b9b8
Uncomment tests I had commented for debugging
ChristopherRabotin b18ecf6
Trying to cleanup the compute_gregorian function
ChristopherRabotin 0496fda
Down to one failing test
ChristopherRabotin ddb63b4
Down to one failing test
ChristopherRabotin 6cab465
Found the remaining bug in the Gregorian computation
ChristopherRabotin a1e0846
Lint
ChristopherRabotin 39a5d43
Fix kani build
ChristopherRabotin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor but it was driving me crazy that a duration of one day was printed in plural form.