Export CCSDS OEM and slight performance improvement on importing them #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Fix bug when printing empty trajectory + Add builder pattern to ExportCfg + Fix export of CCSDS OEM + Only build nyx-fds image when tests succeed
|
Visit the preview URL for this PR (updated for commit 788b5a1): https://nyx-rustdoc--pr184-183-ccsds-oem-import-e8y5ns2m.web.app (expires Sun, 18 Jun 2023 16:02:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
ChristopherRabotin
changed the title
ChristopherRabotin
deleted the
183-ccsds-oem-import-is-slow-export-not-yet-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects
The performance improvement on reading a CCSDS OEM file is very minor in the tests, but that may be because these files are small. It's likely that the performance gain will be noticeable on large files.
There is more work to be done notably on the question of what to do with the TrajectoryLoader and whether it should be made obsolete and replaced by OrbitTrajPy + upcast() when a spacecraft trajectory is needed.Conclusion: keep the trajectory loader for now as it pickles well. Eventually, I'll need to come up with a better solution.Closes #183
If this is a new feature or a bug fix ...
issue-xyzwherexyzis the number of the issue.If this change adds or modifies a validation case