-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp tracking schedule building #261
Merged
ChristopherRabotin
merged 23 commits into
master
from
hotfix/tracking-schedule-not-applied
Dec 23, 2023
Merged
Revamp tracking schedule building #261
ChristopherRabotin
merged 23 commits into
master
from
hotfix/tracking-schedule-not-applied
Dec 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit c5bd169): https://nyx-rustdoc--pr261-hotfix-tracking-sche-2qbe6whg.web.app (expires Sat, 30 Dec 2023 08:31:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
This is a pretty useful feature for ground station passes, which I'll implement right away.
This is both realistic and very fast.
Test results are still poor and I'm really not sure why.
Working on fixing the other ones which use the schedule. It's probably a change in the measurement generation that causes the issue.
For robustness test, I had to increase the tolerance by an order of magnitude. I explain this because this test uses the new tracking set up. This one uses the actual event of rising above the horizon to find when to start tracking. It causes the OD propagator and the truth propagator to take a different step size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects
Includes breaking changes for the TrkConfig.
There was an attempt at building a tracking schedule while the measurements were generated. This led to a few unrealistic set ups, including the fact that the sampling rate could be wrong because of some attempt at being clever would fail.
This PR changes how TrkConfig is set up. There no longer is a start and end time per se. Instead, there's a scheduler, which will always schedule on visibility (defined as elevation > 0, regardless of the elevation mask of the ground station), and a cadence (either Continuous or Intermittent with an on/off tracking). From the scheduler, a set of "tracking strands" are built: these correspond to start/stop times during which the vehicle is over the horizon (in the SEZ frame of the ground station). Then, there is a "hand off" strategy that determines how to handle the case where several ground stations can see the vehicle.
Fixes #260
Measurement plots
The following plots used this configuration:
No type specified
Shows all tracking strands:
Ranging data
Fuzzy matching on column name:
plot_measurements(msr_df, "range")
Doppler data
Fuzzy matching on column name:
plot_measurements(msr_df, "dop")
TODO
P.S.: This PR likely includes quite a bit more work.