Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy evaluation on avail error list #274

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

cmleinz
Copy link
Contributor

@cmleinz cmleinz commented Jan 26, 2024

Effects

Lazily evaluate the avail error list to keep the happy path free of unnecessary allocations.

If this is a new feature or a bug fix ...

  • Yes, the branch I'm proposing to merge is called issue-xyz where xyz is the number of the issue.

If this change adds or modifies a validation case

  • No.
  • Yes and:
    • I have coded up, or updated, an existing test case; and
    • I have provided a GMAT script which confirms the result(s); and
    • I have updated the VALIDATION.md file with the new error data between nyx and GMAT.
    • I will specify the version of GMAT used for the validation.

@ChristopherRabotin
Copy link
Member

Looks good, thanks! I'll be starting to integrate ANISE in Nyx shortly, but that will likely take several weeks.

I'm a bit surprised about the docker error in the packaging step of python. I suspect that's because you don't own the repo, so I'll ignore that issue and expect it to resolve itself.

@ChristopherRabotin ChristopherRabotin merged commit 9b2ed84 into nyx-space:master Jan 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants