Reduce number of generics for propagator options #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a9444f5): https://nyx-rustdoc--pr367-366-reduce-number-of-1qupscnq.web.app (expires Mon, 07 Oct 2024 05:31:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
ChristopherRabotin
deleted the
366-reduce-number-of-generics-for-propagator-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major architectural change
Closes #366
Architectural Changes
ErrorControlRKis no longer a trait and the selection of the Runge Kutta method is now done via the IntegratorMethod enumThese changes will make interoperability in Python MUCH simpler, and speeds up compilation times by ~50 seconds.
New Features
No change
Improvements
No change
Bug Fixes
No change
Testing and validation
No change because this does not affect any of the logic.
Documentation
This PR does not primarily deal with documentation changes.