Bound the proposed integrator steps #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 96b29b3): https://nyx-rustdoc--pr378-fix-gh-377-onz4tr30.web.app (expires Mon, 25 Nov 2024 07:21:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
… (was preventing negative steps!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The minimum step check was sometimes bypassed when updating the step size for the next integration cycle. This could cause the minimum integration step size to be zero, thereby hanging forever. This PR also prevents NaN from showing up in the solution of an integration by stopping the integration and recommending solutions.
This PR fixes #377 where this bug was identified. Thanks @gregjesl !
Architectural Changes
No change
New Features
No change
Improvements
Propagation reporting now shows the current step size as well.
Bug Fixes
Integrator steps are now always within integrator option bounds.
Testing and validation
No changes to the test themselves, but I tested the fix on the code from the bug report.
Documentation
This PR does not primarily deal with documentation changes.