Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Dated show name (original letter case) not working (related to #49) #52

Closed
fleXible opened this issue Aug 22, 2019 · 2 comments
Closed

Dated show name (original letter case) not working (related to #49) #52

fleXible opened this issue Aug 22, 2019 · 2 comments

Comments

@fleXible
Copy link
Contributor

fleXible commented Aug 22, 2019 •
edited
Loading

Because the code used in DatedFormat to create the show name specifiers is a copy of the buggy code leading to #49 they both share the issue but have to be fixed separately.

The current issues with DatedFormat are:

  • %sN, %s.N, %s_N specifiers not working as expected
  • empty %desc, %.desc, %_descspecifiers instead of episode specifiers are created. See DatedFormat is missing Episode related specifiers #51
  • %t, %.t, %_t specifiers are created and even used in the tests, but undocumented and refer to movie title

Related issues with movie title (original letter case) specifiers:
@fleXible fleXible mentioned this issue Aug 22, 2019
Closed
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 25, 2019
@fleXible
fix: Case-adjustments for series name specifiers not working
6dc4298 
The series name specifiers **%sn, %s.b, %s_n** and **%sN, %s.N, %s_N** were
based on buggy code from MoviesFormat.

The new implementation is based on the correctly working SeriesFormat code and
proper test cases were added.

See: nzbget#52
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 25, 2019
@fleXible
fix: Remove invalid %desc specifier from DatedFormat
3adb85a 
Since the %desc is not supported by guessit, it would always be empty.
Furthermore no documentation was provided and all dated test cases used it.

The specifier was removed and the test cases adjusted accordingly.

See: nzbget#52
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 25, 2019
@fleXible
feat: Add support to mark specifiers as deprecated
47120e1 
Across the formats, different specifiers are either buggy or undocumented.
To provide a safe way for users to migrate, a deprecation notice has been added.

Mapping tuples now can have a third field with a deprecation message that is
shown to the user as Warning, when the specifier is replaced.

See: nzbget#52
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 25, 2019
@fleXible
fix: Deprecate undocumented DatedFormat specifiers
56e77f6 
Specifiers **%t, %.t, %_t** are meant for movie titles and are
undocumented for DatedFormat.

Newly introduced feature to deprecate specifiers is used to inform user.

Closes nzbget#52
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 25, 2019
@fleXible
fix: Deprecate undocumented DatedFormat specifiers
f17263c 
Specifiers *%t, %.t, %_t* are meant for movie titles and are
undocumented for DatedFormat.

- Newly introduced feature to deprecate specifiers is used to inform user.

Closes nzbget#52
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 25, 2019
@fleXible
fix: Case-adjustments for series name specifiers not working
cf23015 
The series name specifiers %sn, %s.b, %s_n and %sN, %s.N, %s_N were
based on buggy code from MoviesFormat.

The new implementation is based on the correctly working SeriesFormat code and
proper test cases were added.

See: nzbget#52
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 25, 2019
@fleXible
fix: Remove invalid %desc specifier from DatedFormat
a2c83a0 
Since the %desc is not supported by guessit, it would always be empty.
Furthermore no documentation was provided and all dated test cases used it.

The specifier was removed and the test cases adjusted accordingly.

See: nzbget#52
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 25, 2019
@fleXible
feat: Add support to mark specifiers as deprecated
ce7c406 
Across the formats, different specifiers are either buggy or undocumented.
To provide a safe way for users to migrate, a deprecation notice has been added.

Mapping tuples now can have a third field with a deprecation message that is
shown to the user as Warning, when the specifier is replaced.

See: nzbget#52
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 25, 2019
@fleXible
fix: Deprecate undocumented DatedFormat specifiers
fee895c 
Specifiers %t, %.t, %_t are meant for movie titles and are
undocumented for DatedFormat.

Newly introduced feature to deprecate specifiers is used to inform user.

Closes nzbget#52
fleXible added a commit to fleXible/VideoSort that referenced this issue Aug 26, 2019
@fleXible
fix: MovieFormat title (original letter case) specifiers
8e17fa0 
Specifiers %tT, %t.T, %t_T (original letter case) were converting case
and the test case wrongly checked for case transformation.

Naming of variables has been changed, so the ones holding the transformed
data start with a "t".

Test cases have been adjusted or extended accordingly.

Closes nzbget#52
hugbug pushed a commit that referenced this issue Aug 28, 2019
@fleXible @hugbug
Fix/dated show name (#54)
314f9f4 
#52, #53, #54: fix DatedFormat and original letter case specifiers
@hugbug
Copy link
Member

hugbug commented Aug 28, 2019

Can this be closed now?

@fleXible
Copy link
Contributor Author

Yes, finally!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fleXible @hugbug