Expose remaining gates #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
force-pushed
the
feature/expose-all-gates
branch
from
6e23de6 to
0823354
Compare
Trivo25
approved these changes
Nov 1, 2023
| let ec_add p1 p2 p3 inf same_x slope inf_z x21_inv = | ||
| add_gate "ec_add" | ||
| (EC_add_complete { p1; p2; p3; inf; same_x; slope; inf_z; x21_inv }) ; | ||
| (* TODO: do we need this? *) |
There was a problem hiding this comment.
I think we dont. That was probably my fault when I originally rewrote the Group.add function in TypeScript
https://github.com/o1-labs/o1js/blob/main/src/lib/group.ts#L173-L181
can probably just return
(x3, y3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plonk_constraint_system.ml