Remove top-level await #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
commented
Apr 16, 2024
| @@ -23,13 +21,11 @@ let workerPromise; | |||
| */ | |||
| let numWorkers = undefined; | |||
|
|
|||
| let isInitialized = false; | |||
| async function initializeBindings() { | |||
| wasm = plonkWasm(); | |||
There was a problem hiding this comment.
I moved this here to make the initial loading time even faster (< 20ms)
There was a problem hiding this comment.
Is there any use in returning from the function early if wasm is already defined? Let's say we accidentally call initializeBindings() twice, does that mean we have to wait for loading twice?
There was a problem hiding this comment.
Yeah that's very important! I moved the early return logic into snarky.web.js, through which this function will always be called
ymekuria
approved these changes
Apr 16, 2024
MartinMinkov
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion for o1-labs/o1js#1583