Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Fetch.fetchActions to derive actionHash from any block instead of calculating from beginning #802

Closed
MartinMinkov opened this issue Mar 21, 2023 · 1 comment · Fixed by #828
Closed

Allow Fetch.fetchActions to derive actionHash from any block instead of calculating from beginning #802

MartinMinkov opened this issue Mar 21, 2023 · 1 comment · Fixed by #828
Assignees
@MartinMinkov

Comments

@MartinMinkov
Copy link
Contributor

No description provided.

@MartinMinkov MartinMinkov mentioned this issue Apr 3, 2023
Merged
@MartinMinkov
Copy link
Contributor Author

Work done for to support this in Archive Node API is done here: o1-labs/Archive-Node-API#71

@MartinMinkov MartinMinkov mentioned this issue Apr 4, 2023
Merged
@MartinMinkov MartinMinkov linked a pull request Apr 4, 2023 that will close this issue
Add endActionState and fromActionState to fetchActions #828
Merged
@MartinMinkov MartinMinkov self-assigned this Apr 4, 2023
MartinMinkov added a commit to o1-labs/Archive-Node-API that referenced this issue Apr 5, 2023
@MartinMinkov
Add actions filtering based on fromActionHash and endActionHash +…
0916189 
… return all action states for each block (#71)

## Description
:link: Laying the groundwork for o1-labs/o1js#802

In this PR, we introduce an enhancement that enables users to filter
actions based on their action hash within each block. By specifying
fromActionHash or endActionHash, users can now filter actions according
to the action hash. This improvement allows SnarkyJS users to simply
provide the desired action hashes, eliminating the need to derive them
from the entire actions history. As a result, SnarkyJS experiences a
performance boost, since it no longer needs to compute a large number of
hashes.

Additionally, we return all action states for each block. SnarkyJS can
use `actionStateTwo` to recalculate the new actions hash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinMinkov MartinMinkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add endActionState and fromActionState to fetchActions o1-labs/o1js
1 participant
@MartinMinkov