Expose and test rangeCheck64 gadget #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MartinMinkov
approved these changes
Oct 12, 2023
Trivo25
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose the range check gate added in #1176 and add a unit test
Notes:
Most of this PR consists of refactoring the
equivalence()testing framework that I wanted use for the new test.I really liked the easy-to-write and type-safe way of how I used this framework in the bindings unit test, that's why I decided to move it from the bindings repo to o1js and consolidate it with the equivalence testing logic that was already there. For a good idea of how these tests are done, see the field unit test (which changed a lot in this PR)
bindings: o1-labs/o1js-bindings#183