Code

Add rot gadget to o1js#1182

Code

Merged

MartinMinkov merged 84 commits intomaino1-labs/o1js:mainfrom feat/ROT-gadgeto1-labs/o1js:feat/ROT-gadgetCopy head branch name to clipboardOct 26, 2023

+329-41

Commits

Commits on Oct 12, 2023

• chore(bindings): update submodule for rot gate

  MartinMinkov

  committed
  4afed25

  Copy full SHA for 4afed25

• feat(snarky.d.ts): add 'rot' function to Snarky interface to support rotation operations

  MartinMinkov

  committed
  6bdcbbf

  Copy full SHA for 6bdcbbf

Commits on Oct 16, 2023

• feat(gates.ts): add rot function

  MartinMinkov

  committed
  ddb9200

  Copy full SHA for ddb9200

• feat(rot.ts): add new rotation function for bitwise operations

  Show description for 65d97be
  MartinMinkov

  committed
  65d97be

  Copy full SHA for 65d97be

• chore(bindings): update bindings subproject to latest commit

  MartinMinkov

  committed
  e69a93f

  Copy full SHA for e69a93f

• refactor(snarky.d.ts): replace hardcoded arrays with MlArray<FieldVar> for limbs and crumbs

  MartinMinkov

  committed
  e040fe7

  Copy full SHA for e040fe7

• feat(gates.ts): add MlArray import to convert limbs and crumbs arrays to MlArray

  MartinMinkov

  committed
  82dfa33

  Copy full SHA for 82dfa33

• feat(rot.ts): implement provable rotation function

  MartinMinkov

  committed
  a63c0d3

  Copy full SHA for a63c0d3

• refactor(rot.ts): simplify rot function by removing unnecessary checks and conditions

  MartinMinkov

  committed
  19bfedf

  Copy full SHA for 19bfedf

• feat(field.ts): add rot64 method to Field class for bit rotation

  MartinMinkov

  committed
  1909678

  Copy full SHA for 1909678

• feat(field.unit-test.ts, int.ts): add rotation test

  MartinMinkov

  committed
  a94394f

  Copy full SHA for a94394f

• fix(rot.ts): correct condition to check if word is more than 64 bits

  MartinMinkov

  committed
  eed078c

  Copy full SHA for eed078c

• docs(CHANGELOG.md): add entry for bitwise ROT operation support for native field elements

  MartinMinkov

  committed
  60517f3

  Copy full SHA for 60517f3

• refactor(rot.ts): replace hardcoded value 64 with constant MAX_BITS

  MartinMinkov

  committed
  b8cc337

  Copy full SHA for b8cc337

• refactor(rot.ts): extract rotation logic into separate rotate function

  MartinMinkov

  committed
  3c8dd48

  Copy full SHA for 3c8dd48

• fix(rot.ts): correct error message to match function name 'rot'

  MartinMinkov

  committed
  eba9209

  Copy full SHA for eba9209

• refactor(rot.ts): simplify computation and conversion of rotated, excess, shifted, bound values for readability

  MartinMinkov

  committed
  8945d7f

  Copy full SHA for 8945d7f

• refactor: rename rot64 method to rot in field.ts, field.unit-test.ts, int.ts

  MartinMinkov

  committed
  6745559

  Copy full SHA for 6745559

• feat(field.ts, int.ts): add default values for bits parameter in rot method to improve usability

  Show description for e0bcb0f
  MartinMinkov

  committed
  e0bcb0f

  Copy full SHA for e0bcb0f

• fix(field.ts, int.ts): correct the documentation for the rot function

  Show description for e8e0c51
  MartinMinkov

  committed
  e8e0c51

  Copy full SHA for e8e0c51

• feat(gadgets.ts): add example e2e test

  MartinMinkov

  committed
  6f3a6c5

  Copy full SHA for 6f3a6c5

Commits on Oct 17, 2023

• refactor(rot.ts): split rot function into rot and rotate

  MartinMinkov

  committed
  cd024e5

  Copy full SHA for cd024e5

• feat(gadgets.ts): add more test cases

  MartinMinkov

  committed
  704c2d9

  Copy full SHA for 704c2d9

• chore(rot.ts): minor refactors

  MartinMinkov

  committed
  fb347bd

  Copy full SHA for fb347bd

• feat(gadgets.ts): enhance testRot function to log output for better debugging

  MartinMinkov

  committed
  98bd547

  Copy full SHA for 98bd547

• refactor(gadgets.ts): change testRot function parameters from number to string to avoid precision loss in JavaScript

  MartinMinkov

  committed
  cc2d158

  Copy full SHA for cc2d158

• refactor(rot.ts): update comment for clarity on the role of the prover in checking the input word length

  MartinMinkov

  committed
  b7698a6

  Copy full SHA for b7698a6

• chore(bindings): update subproject commit hash to latest version for up-to-date dependencies

  MartinMinkov

  committed
  1e1f46e

  Copy full SHA for 1e1f46e

• Merge branch 'main' into feat/ROT-gadget

  MartinMinkov

  committed
  09585d2

  Copy full SHA for 09585d2

• feat(gadgets.ts): add rot function to Gadgets namespace for bit rotation

  Show description for b7b01a3
  MartinMinkov

  committed
  b7b01a3

  Copy full SHA for b7b01a3

• docs(field.ts, int.ts): rearrange and add more details to the rot method documentation

  MartinMinkov

  committed
  3f1de40

  Copy full SHA for 3f1de40

• feat(gadgets.unit-test.ts): add ROT ZkProgram and its equivalentAsync test

  MartinMinkov

  committed
  c0210c3

  Copy full SHA for c0210c3

• feat: add rot tests to primitive_constraint_system and vk_regression

  MartinMinkov

  committed
  22050e1

  Copy full SHA for 22050e1

• feat(regression_test.json): add 'Bitwise Primitive' test case to extend test coverage

  MartinMinkov

  committed
  ea73c6a

  Copy full SHA for ea73c6a

• Revert "feat(field.ts, int.ts): add default values for bits parameter in rot method to improve usability"

  Show description for 95a4559
  MartinMinkov

  committed
  95a4559

  Copy full SHA for 95a4559

• feat(rot): fix unit tests by only using Gadgets namespace for public API

  MartinMinkov

  committed
  8f53db3

  Copy full SHA for 8f53db3

• chore(rot): minor doc and vk updates

  MartinMinkov

  committed
  d86a4c8

  Copy full SHA for d86a4c8

• chore(bindings): update bindings for compiled ROT artifacts

  MartinMinkov

  committed
  39328bf

  Copy full SHA for 39328bf

• feat(rot): minor refactor to rot gate checks and add range check to rotated word

  MartinMinkov

  committed
  300427c

  Copy full SHA for 300427c

• fix(gadgets.unit-test.ts): add await keyword to equivalentAsync function calls to ensure tests run asynchronously and complete before proceeding

  MartinMinkov

  committed
  cd2c344

  Copy full SHA for cd2c344

• fix(regression_test.json): update 'rows' and 'digest' values in 'rot' method to reflect recent changes in the test data

  MartinMinkov

  committed
  7de9b16

  Copy full SHA for 7de9b16

Commits on Oct 18, 2023

• refactor(rot.ts): simplify witnessSlices function

  MartinMinkov

  committed
  a77d0a8

  Copy full SHA for a77d0a8

• Revert "refactor(rot.ts): simplify witnessSlices function"

  Show description for fdc1061
  MartinMinkov

  committed
  fdc1061

  Copy full SHA for fdc1061

Commits on Oct 21, 2023

• chore(bindings): update subproject commit hash to aa7f880 for latest changes in the subproject

  MartinMinkov

  committed
  e795fb4

  Copy full SHA for e795fb4

• Merge branch 'main' into feat/ROT-gadget

  MartinMinkov

  committed
  ca4be42

  Copy full SHA for ca4be42

Commits on Oct 22, 2023

• refactor(gadgets.ts): move testRot function and related tests to gadgets.unit-test.ts

  MartinMinkov

  committed
  0442672

  Copy full SHA for 0442672

• refactor(gadgets.unit-test.ts): convert inputs for rot to strings

  MartinMinkov

  committed
  5b0de01

  Copy full SHA for 5b0de01

• refactor(gadgets.ts): simplify witness creation and rotation operations

  MartinMinkov

  committed
  de2c091

  Copy full SHA for de2c091

• refactor(rot.ts): modify witnessSlices and change inputs to rot gate

  MartinMinkov

  committed
  e3264ec

  Copy full SHA for e3264ec

Commits on Oct 23, 2023

• refactor(rot.ts): simplify direction param usage

  MartinMinkov

  committed
  97af12c

  Copy full SHA for 97af12c

• refactor(field.unit-test.ts): remove rotation test from field.unit-test.ts

  MartinMinkov

  committed
  20f10a0

  Copy full SHA for 20f10a0

• fix(gadgets.ts): change expectedRight from integer to Field object to match the type of actualRight for correct comparison

  MartinMinkov

  committed
  9696ff0

  Copy full SHA for 9696ff0

• fix(rot.ts): use BigInt for comparison to handle large numbers correctly

  Show description for 27efd59
  MartinMinkov

  committed
  27efd59

  Copy full SHA for 27efd59

• refactor(rot.ts): extract max bits check into a separate function to reduce code duplication

  MartinMinkov

  committed
  ef864c5

  Copy full SHA for ef864c5

• refactor(gadgets.ts, gadgets.unit-test.ts, rot.ts, gates.ts, snarky.d.ts): rename 'word' to 'field' for better clarity and consistency in code

  MartinMinkov

  committed
  c4a261e

  Copy full SHA for c4a261e

• fix(rot.ts): replace 'rotated' with 'field' in rangeCheck64 function to correct the variable being checked

  MartinMinkov

  committed
  0f31fee

  Copy full SHA for 0f31fee

• fix(regression_test.json): update digest value in rot method to ensure test consistency with latest changes

  MartinMinkov

  committed
  10b8be9

  Copy full SHA for 10b8be9

Commits on Oct 25, 2023

• chore(bindings): update subproject commit hash to fcda5090bc6bf433188c5152253d8370c25685c6 for latest changes

  MartinMinkov

  committed
  358105d

  Copy full SHA for 358105d

• feat(gadgets.ts): update doc comment

  Show description for 87d5601
  

  MartinMinkov

  and

  mitschabaude

  authored
  87d5601

  Copy full SHA for 87d5601

• Merge branch 'feat/ROT-gadget' of github.com:o1-labs/snarkyjs into feat/ROT-gadget

  MartinMinkov

  committed
  7dc93e1

  Copy full SHA for 7dc93e1

• refactor(rot.ts): remove direction check in rot function

  MartinMinkov

  committed
  33aff5c

  Copy full SHA for 33aff5c

• refactor(rot.ts, gates.ts): replace Field type with bigint for two_to_rot variable

  MartinMinkov

  committed
  00530af

  Copy full SHA for 00530af

• fix(rot.ts): remove unnecessary range check on 'field' variable

  MartinMinkov

  committed
  1948ea4

  Copy full SHA for 1948ea4

• refactor(gadgets.ts): change numeric literals to binary

  MartinMinkov

  committed
  c188a56

  Copy full SHA for c188a56

• docs(CHANGELOG.md): update method description for bitwise rotation operation to provide more clarity on its functionality

  MartinMinkov

  committed
  8a98da9

  Copy full SHA for 8a98da9

• feat(gadgets): rename rot to rotate

  MartinMinkov

  committed
  1f9fb24

  Copy full SHA for 1f9fb24

• refactor(rot.ts): simplify comments for better readability

  MartinMinkov

  committed
  b395950

  Copy full SHA for b395950

• fix(rot.ts): adjust validation range for rotation bits to exclude 0 and MAX_BITS

  MartinMinkov

  committed
  142e30f

  Copy full SHA for 142e30f

• refactor(gadgets.unit-test.ts): simplify testRot function by removing unnecessary witness calls

  MartinMinkov

  committed
  b9ef95e

  Copy full SHA for b9ef95e

• docs(gadgets.ts): enhance explanation of rotation operation and its constraints

  MartinMinkov

  committed
  fbe8aa5

  Copy full SHA for fbe8aa5

Commits on Oct 26, 2023

• Revert "fix(rot.ts): adjust validation range for rotation bits to exclude 0 and MAX_BITS"

  Show description for 8c50792
  MartinMinkov

  committed
  8c50792

  Copy full SHA for 8c50792

• refactor(rot.ts): remove redundant checkMaxBits function call to improve performance

  Show description for 36415ad
  MartinMinkov

  committed
  36415ad

  Copy full SHA for 36415ad

• Merge branch 'main' into feat/ROT-gadget

  MartinMinkov

  committed
  2f62bb1

  Copy full SHA for 2f62bb1

• fix(regression_test.json): update 'rot' method's rows and digest values to reflect recent changes

  MartinMinkov

  committed
  b077078

  Copy full SHA for b077078

• refactor(gadgets.ts): rename 'rot' function to 'rotate'

  MartinMinkov

  committed
  9075a94

  Copy full SHA for 9075a94

• docs(CHANGELOG.md): update description for XOR operation to match format of other entries for consistency

  MartinMinkov

  committed
  03b4988

  Copy full SHA for 03b4988

• refactor(bitwise.ts): merge rotate function from rot.ts into bitwise.ts

  MartinMinkov

  committed
  e2ff992

  Copy full SHA for e2ff992

• docs(gadgets.ts): enhance documentation for XOR gadget function

  Show description for 6405b75
  MartinMinkov

  committed
  6405b75

  Copy full SHA for 6405b75

• refactor(bitwise.ts, common.ts): extract common functions and constants to a separate file

  MartinMinkov

  committed
  131bce2

  Copy full SHA for 131bce2

• Merge branch 'main' into feat/ROT-gadget

  MartinMinkov

  committed
  e950076

  Copy full SHA for e950076

• feat(range-check.unit-test.ts): add name property to ROT ZkProgram

  MartinMinkov

  committed
  eeabe7c

  Copy full SHA for eeabe7c

• fix(range-check.unit-test.ts): change Field value from string to BigInt

  MartinMinkov

  committed
  6f2a0dd

  Copy full SHA for 6f2a0dd

• fix(bitwise.ts): adjust rotation bits range check to include 0 and MAX_BITS

  MartinMinkov

  committed
  e48c5e4

  Copy full SHA for e48c5e4

• refactor(bitwise.unit-test.ts): move rot tests from range-check.unit-test.ts to bitwise.unit-test.ts

  MartinMinkov

  committed
  7cd98ee

  Copy full SHA for 7cd98ee