Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encryption v2 #1729

Merged
merged 21 commits into from
Jul 30, 2024
Merged

Encryption v2 #1729

merged 21 commits into from
Jul 30, 2024

Conversation

Trivo25
Copy link
Member

@Trivo25 Trivo25 commented Jul 9, 2024 •
edited
Loading

No description provided.

@Trivo25 Trivo25 mentioned this pull request Jul 9, 2024
Closed
mitschabaude
mitschabaude reviewed Jul 10, 2024
View reviewed changes
src/lib/provable/crypto/encryption.ts Outdated Show resolved Hide resolved
src/lib/provable/crypto/encryption.ts Outdated Show resolved Hide resolved
@Trivo25 Trivo25 marked this pull request as ready for review July 10, 2024 15:29
mitschabaude
mitschabaude reviewed Jul 30, 2024
View reviewed changes
src/lib/provable/crypto/encryption.ts Outdated Show resolved Hide resolved
src/lib/provable/crypto/encryption.ts Outdated Show resolved Hide resolved
src/lib/provable/crypto/encryption.ts Outdated Show resolved Hide resolved
src/examples/encryptionv2.ts Outdated Show resolved Hide resolved
mitschabaude
mitschabaude approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still recommend to have the example use more than 31 chars (that are not zero-padding) as a sanity check, otherwise lgtm

@Trivo25 Trivo25 merged commit 7d8f8a1 into main Jul 30, 2024
24 checks passed
@Trivo25 Trivo25 deleted the v2-encryption branch July 30, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trivo25 @mitschabaude