Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TokenContract to not use depricated methods #1776

Closed
wants to merge 6 commits into from
Closed

Update TokenContract to not use depricated methods #1776

wants to merge 6 commits into from

Conversation

ymekuria
Copy link
Contributor

@ymekuria ymekuria commented Jul 26, 2024 •
edited
Loading

Summary

This PR removes the use of deprecated APIs within the TokenContract.

Changes

  • AccountUpdate.defaultAccountUpdate() was replaced with AccountUpdate.default().
  • Int64.neg() was replaced with Int64.negV2().

@ymekuria ymekuria marked this pull request as ready for review July 26, 2024 18:11
Trivo25
Trivo25 requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use negV2 in the V1 token contract, this will break the existing constraint system

@mitschabaude
Copy link
Collaborator

Should go to v2!

@ymekuria ymekuria self-assigned this Sep 27, 2024
@ymekuria ymekuria changed the base branch from main to v2 October 3, 2024 05:23
@Trivo25
Copy link
Member

Trivo25 commented Oct 18, 2024

done

@Trivo25 Trivo25 closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trivo25 Trivo25 Trivo25 requested changes

Assignees

@ymekuria ymekuria

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ymekuria @mitschabaude @Trivo25