Allow non-pure provable types as inputs/outputs in zkprogram #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ProvablePure to Provable
…m ProvablePure to Provable
…gram state for zk programs
…or clarity and consistency with its purpose
…e for better clarity and consistency in naming conventions
…r setting auxiliary output values
…ram function for future use and flexibility
…t for consistency and clarity
…r clarity and consistency
…to 'setAuxiliaryInput' for consistency
…f996b6ac35373dc27084ef
…by returning an empty array instead of throwing an error
…n favor of merging if else logic to improve readability
…utProgram example to handle case with only non-pure output
…e proof object for better readability and consistency in accessing proof properties
…nd publicInputAux by merging non-pure and pure input branch cases into one.
…p code and improve readability
…rack latest changes
querolita
reviewed
Nov 25, 2024
…rogram to clean up code and improve readability docs(program-with-non-pure-input.ts): remove console logs related to NonPureInputProgram compilation for clarity and cleanliness
Trivo25
approved these changes
Nov 27, 2024
| console.log('compile done'); | ||
| let input = new MyStruct({ label: 'input', value: Field(5) }); | ||
| let proof; | ||
| ({ proof } = await NonPureIOprogram.baseCase(input)); |
There was a problem hiding this comment.
i actually didn't know you could reassign a deconstructed value without redeclaring the variable! :D
mitschabaude
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
implementation-wise, looks good to me!
we just have a problem with converting proofs to/from JSON now: proofs are serialized by doing toFields() on publicInput and publicOutput and converting these fields to strings. this will work in toJSON(), but will fail in fromJSON() where the aux part in fromFields() will be missing.
to solve that we'd need a general way to serialize any provable type. I have some ideas on that that I might post in a separate issue
|
huge simplification for so many zkprograms! 🥳 |
…le from o1js to clean up code and improve readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
ZkProgramto allow non-pure provable types as inputs and outputs.Addresses #1675
Impact
Currently only pure provable types can be used as inputs and outputs to a
ZkProgram. This PR improves the DX with changes that allow a developer to update rich provable types like aIndexedMerkleMapor aMerkleListin aZkProgram.