fix fetchEvents
#628
Merged
fix fetchEvents
#628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
reviewed
Dec 5, 2022
| @@ -1001,11 +1001,11 @@ super.init(); | |||
| // if there are multiple events we have to use the index event[0] to find the exact event type | |||
| let type = sortedEventTypes[event[0]]; | |||
| // all other elements of the array are values used to construct the original object, we can drop the first value since its just an index | |||
| event.shift(); | |||
| let eventProps = event.slice(1); | |||
There was a problem hiding this comment.
isn't this equivalent? 😮
I'd love to understand what the issue here was and how this fixes it
There was a problem hiding this comment.
The bug appeared when we called fetchEvents more than once, because shift manipulates the original array, slice doesn't.
So every time we called fetchEvents, we would drop an element of the original array until the array would be empty
mitschabaude
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #627