Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't increment nonces on accounts that are the fee payer #637

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Dec 7, 2022

  • closes Don't increment nonces on accounts that are the fee payer #271
  • tweak the implementation of AccountUpdate.createSigned, to use create and requireSignature(). Deprecate the API where a private key is passed to createSigned() -- we want to move away from private keys in transactions. Instead, add another function signature that takes a public key.
  • breaking change to the circuit used in requireSignature() -- this will break many deployed contracts and thus require a minor version bump

Copy link
Contributor

@MartinMinkov MartinMinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change! Everything checks out on my end :D

@mitschabaude mitschabaude merged commit fb09467 into main Dec 8, 2022
@mitschabaude mitschabaude deleted the feature/use-full-commitment branch December 8, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't increment nonces on accounts that are the fee payer
2 participants