-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/apple silicon performance #683
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2dc0dc1
Install detect-gpu
jackryanservia f75c50c
Detect Apple silicon
jackryanservia 3078029
Update SnarkyJS bindings
jackryanservia 1f94ea2
Merge branch 'main' into fix/apple-silicon-performance
jackryanservia 7d7b367
Added to CHANGELOG
jackryanservia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { getGPUTier } from 'detect-gpu'; | ||
|
||
export { getEfficientNumWorkers as default }; | ||
|
||
// Return the most efficient number of workers for the platform we're running | ||
// on. This is required because of an issue with Apple silicon that's outlined | ||
// here: https://bugs.chromium.org/p/chromium/issues/detail?id=1228686 | ||
async function getEfficientNumWorkers() { | ||
let gpuTier = await getGPUTier(); | ||
let numCpus = navigator.hardwareConcurrency; | ||
// gpuTier.gpu is undefined if page was rendered server side | ||
let gpuModel = gpuTier.gpu || 'SSR'; | ||
|
||
var numWorkers = | ||
{ | ||
'apple m1': 2, | ||
'apple m1 pro': numCpus === 10 ? 3 : 2, | ||
'apple m1 max': 3, | ||
'apple m1 ultra': 7, | ||
'apple m2': 2, | ||
'SSR': ((numCpus / 6) >> 0) + 1, | ||
}[gpuModel] || numCpus - 1; | ||
|
||
return numWorkers; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you elaborate on that case? I'd assume that if server-side rendering prevents
getGPUTier
from running on the client, then snarkyjs won't run on the client in its entirety, so this case doesn't really matter? Or am I wrong?