Add analyzeMethods() to ZkProgram #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
approved these changes
Apr 5, 2023
| expect(incrementMethodMetadata).toEqual( | ||
| expect.objectContaining({ | ||
| rows: 18, | ||
| digest: '62d893f727b12d540bdc483427cbd70b', |
There was a problem hiding this comment.
can we remove the digest here and in the other test? otherwise this will break every time pickles internal circuits change
There was a problem hiding this comment.
ah, never mind, this just gets the circuit created from the method directly, without extra stuff added by pickles. should be fine
There was a problem hiding this comment.
Can you please shine a bit more light in what you meant by ‘extra stuff added by pickles’? Do you mean the wrap circuit in SmartContract or something? 🧐
|
@maht0rz one ask before I merge this - can you add your addition to CHANGELOG.md? |
|
@mitschabaude i will add it to the changelog and ping you once i’m done thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #827 and adds a simple unit test for the
proof_system.tsto test it.I have encountered a few issues when implementing this:
analyzeMethod, so i've used itsReturnTypeinstead.run-unit-tests.shdoes not work on Mac due to using features available on bash v4+ (mac runs bash v3). I have installed bash v5 with brew and ran unit tests by hand like this to workaround this issue:/opt/homebrew/bin/bash ./run-unit-tests.sh. This could be solved for the long term by replacing/bin/bashin the shell scripts to respect the user env, more information hereQuestion on the side -Answer:.github/workflows/build-action.ymldoes not seem to run unit tests. When/where do the unit tests run, assuming they're part of the CI?run-ci-tests.sh