Improve error when reading variable in provable code #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #899
closes #478
closes #489
bindings: o1-labs/o1js-bindings#52
Consider this method which incorrectly tries to extract the JS value of a variable:
We used to get an error that confused people again & again:
This frequently caused people to wrap their entire logic in
Provable.asProver(...)
😬With this PR, the error now looks like:
Equivalent error messages happen in methods such as
Bool.toBoolean()
,Field.toBigInt()
andPublicKey.toBase58()
. We took care to adapt the error message to refer to a method that a user likely called themselves - e.g., refer toPublicKey.toBase58()
in the error message even though it causes the error by internally callingField.toBigInt()
.