Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort queries by modification date #307

Closed
DmitryKey opened this issue Mar 29, 2021 · 9 comments
Closed

Add sort queries by modification date #307

DmitryKey opened this issue Mar 29, 2021 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DmitryKey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Sort queries by modification time. Can be very useful when there are several screens of queries and you need only portion that has been annotated / rated.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Add "modification date" to:
Screenshot 2021-03-29 at 22 22 00

Describe alternatives you've considered
Manual drag and drop of queries, but this does not work for multipage situation (I have 65 queries in a single case).

@DmitryKey
Copy link
Contributor Author

hey @epugh I'm thinking to work on this one. I will start by tracing the code for the current sort fields and see where this leads to.

@epugh
Copy link
Member

epugh commented Apr 10, 2021

Great... I believe this all happens in the front end angular code... And there are some exampples to copy. I tend to use lots of console.log(); to figure things out, and lots of refreshing the browser ;-)

During next Friday's Quepid Qommunity Qoding session I can pair with you as well.

@epugh epugh added enhancement New feature or request good first issue Good for newcomers labels Apr 10, 2021
@DmitryKey
Copy link
Contributor Author

Thanks and that'd be awesome to pair on this.
I'm looking at https://itnext.io/debugging-your-angular-application-in-intellij-idea-411a9b08759f as one possible way to ease the process with IDEA.

DmitryKey pushed a commit to DmitryKey/quepid that referenced this issue May 2, 2021
DmitryKey pushed a commit to DmitryKey/quepid that referenced this issue May 2, 2021
DmitryKey pushed a commit to DmitryKey/quepid that referenced this issue May 2, 2021
DmitryKey pushed a commit to DmitryKey/quepid that referenced this issue May 2, 2021
@stale
Copy link

stale bot commented Jul 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 10, 2021
@stale stale bot closed this as completed Aug 10, 2021
@DmitryKey
Copy link
Contributor Author

Fix implemented by Eric in a pair-programming session, including some commits from here

@DmitryKey
Copy link
Contributor Author

@epugh will you reopen this? :)

@epugh
Copy link
Member

epugh commented Sep 6, 2021

Odd, I thought any comments would reopen an issue!

@epugh epugh reopened this Sep 6, 2021
@stale stale bot removed the wontfix This will not be worked on label Sep 6, 2021
@DmitryKey
Copy link
Contributor Author

yep! Well, at least the stale bot has automagically removed the "wontfix" label!

epugh pushed a commit that referenced this issue Sep 8, 2021
* #307 added modified column for sorting queries -- incomplete

* #307 added modified column for sorting queries -- incomplete

* Friday Fun and we got this...

* dead code!??

* lint

* we tested for situations that should never happen

* lint

* merge went crazy and duplicated

* small refactor from deepsource

* deepsource IIFEs should be wrapped JS-0103 fix

* deepsource Found some variables redeclared JS-0085

* establish the test patterns, so we can ignore in tests but not in code running DeepSource

* fix one, uncover another Consider using `let` or `const` instead of `var` JS-0239

* okay deepsource, Use `const` declarations for variables that are never reassigned JS-0242

Co-authored-by: dmitrykan <[email protected]>
Co-authored-by: [email protected] <>
@epugh
Copy link
Member

epugh commented Sep 9, 2021

Okay, it's merged, so going to close this! Release soon!

@epugh epugh closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants