Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of results to show is not preserved when cloning a case #565

Closed
MassimilianoUngheretti-TomTom opened this issue Oct 12, 2022 · 2 comments · Fixed by #578
Closed

Comments

@MassimilianoUngheretti-TomTom

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

  1. Create a case
  2. Edit the "Number of Results to Show" property under "Tune Relevance" to e.g. 42 (default = 10).
  3. Clone the case

Observed behavior
The new case has Number of Results to Show"=10 (default)

Expected behavior
The new case has the same "Number of Results to Show" as the cloned case.

@MassimilianoUngheretti-TomTom
Copy link
Author

I see that in the cloning function there's a missing statement for the number_of_rows property.

@epugh
Copy link
Member

epugh commented Oct 12, 2022

We probably should be using some sort of .clone function that ActiveRecord supplies, this has bit us before.... WOuld you be interested in submitting a patch? Either a .clone or just explicitly copying that line!

epugh added a commit that referenced this issue Oct 27, 2022
@epugh epugh mentioned this issue Oct 27, 2022
epugh added a commit that referenced this issue Oct 27, 2022
* fixes #565

* rubocop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants