Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review jquery usage #121

Merged
merged 11 commits into from
Apr 24, 2020
Merged

Review jquery usage #121

merged 11 commits into from
Apr 24, 2020

Conversation

epugh
Copy link
Member

@epugh epugh commented Apr 24, 2020

Description

Went through our usage of jquery and tried to figure out if we use it or not. Seems like we do use jquery-ui for the drag and drop components on the main interface, but that jquery_ujs ins't used.

Looked at secure.js, application.js, and admin.js.

Motivation and Context

It takes FOREVER to load things in dev. Depending on how you caluate it I did figure out how to make it load 20% or more faster! Maybe from 2.5 minutes to 1.4 minutes?

How Has This Been Tested?

ran the unit tests, and manually clicked around. won't sya it was exhaustive.

Screenshots or GIFs (if appropriate):

Types of changes

  • [S] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh merged commit 3c4c0e4 into master Apr 24, 2020
@epugh epugh deleted the review-jquery branch December 6, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant