Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 146 missing close x checkbox on modals #148

Merged
merged 4 commits into from
Jun 8, 2020

Conversation

epugh
Copy link
Member

@epugh epugh commented Jun 8, 2020

Description

Fixes #146 which is the X box is missing or it doesn't actually close.

Found some styling consistency issues that are fixed too.

Motivation and Context

You expect to click the close at the top and the bottom, with the top being a pattern.

How Has This Been Tested?

By hand and test

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing X box on Create Snapshot
2 participants