Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed "Export Case" and "Import Ratings" to just "Export" and "Import". (#195) #270

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

abhishekChoudhary93
Copy link
Contributor

Description

Renamed "Export Case" and "Import Ratings" to just "Export" and "Import".

Motivation and Context

#195

How Has This Been Tested?

Built changes

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh
Copy link
Member

epugh commented Jan 21, 2021

On this ticket, it would be nice if the components import_ratings in the source files was renamed to import and the export_case was renamed to export, plus the updates to reference those components as <import> instead of <import-ratings> in the javascript. Hence why this is a bit deeper of a ticket!

@epugh
Copy link
Member

epugh commented Feb 19, 2021

I started making more of these changes, and I finally decided that the title should be short, but hte idea that we are exporting queries and case data and snapshots, well, they are all based on a Case of data, so not remaining the files makes sense. Plus, having a component with the name export felt more confusing. So going with your changes.

@epugh epugh merged commit ee9b4d0 into o19s:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the "Export Case" and "Import Ratings" to just "Export" and "Import"?
2 participants