Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish sassc migration #285

Merged
merged 11 commits into from
Mar 9, 2021
Merged

Finish sassc migration #285

merged 11 commits into from
Mar 9, 2021

Conversation

epugh
Copy link
Member

@epugh epugh commented Mar 9, 2021

Description

Turns out we weren't done, and we needed to finish eliminating old pure ruby sass in favour of c based sassc which led me through the wilderness of gems. Plus, guess what, we still have coffee script preprocessing which I swear slowed down loading the web app up!

Maybe shaved 10 seconds off the builds? From 2 min 10 seconds to just udner 2 minutes?

Motivation and Context

Quepid is qrashing on Heroku.

How Has This Been Tested?

unit tests and by hand and on circleci.

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

…we have to update sprockets ;-)

This *appears* to make Quepid load MUCH faster in dev.   Maybe the coffee preprocessor on OSX made loading the app slow...   I know it was slower on OSX than on Windows!!!!
@epugh epugh closed this Mar 9, 2021
@epugh epugh deleted the finish_sassc_migration branch March 9, 2021 21:34
@epugh epugh restored the finish_sassc_migration branch March 9, 2021 21:35
@epugh epugh reopened this Mar 9, 2021
@epugh epugh merged commit 217c6dc into master Mar 9, 2021
@epugh epugh deleted the finish_sassc_migration branch March 9, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant