Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: All team owners are members #286

Merged
merged 12 commits into from
Mar 11, 2021
Merged

WIP: All team owners are members #286

merged 12 commits into from
Mar 11, 2021

Conversation

epugh
Copy link
Member

@epugh epugh commented Mar 10, 2021

Description

Working on perf issues.

First fix was the insight given by folks on #ruby that owners are also members, so we can simplify the access logic to just look for team.members.

Motivation and Context

So slow!

How Has This Been Tested?

unit testsw and by hand.

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh temporarily deployed to quepid-pr-286 March 10, 2021 19:08 Inactive
@epugh epugh temporarily deployed to quepid-pr-286 March 10, 2021 19:22 Inactive
@epugh epugh temporarily deployed to quepid-pr-286 March 10, 2021 19:34 Inactive
@epugh epugh temporarily deployed to quepid-pr-286 March 10, 2021 19:43 Inactive
@epugh epugh temporarily deployed to quepid-pr-286 March 10, 2021 20:36 Inactive
@epugh epugh temporarily deployed to quepid-pr-286 March 10, 2021 21:00 Inactive
@epugh epugh temporarily deployed to quepid-pr-286 March 11, 2021 12:05 Inactive
@epugh epugh merged commit 4a1f255 into master Mar 11, 2021
@epugh epugh deleted the all_team_owners_are_members branch January 8, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant