Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/custom scorers #313

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Fix/custom scorers #313

merged 2 commits into from
Apr 7, 2021

Conversation

worleydl
Copy link
Contributor

@worleydl worleydl commented Apr 7, 2021

Fixes the disappearance of custom scorers.

Description

Missed this view cleanup during previous refactoring, thanks to Jan for pointing it out.

Motivation and Context

Fixes broken view.

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh merged commit a7bd0e1 into master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worleydl @epugh