Email sender from env variable, small prod fixes #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
reviewed
Apr 15, 2021
| - EMAIL_MARKETING_MODE=false | ||
| - DEFAULT_QUEPID_SCORER=AP@10 |
There was a problem hiding this comment.
Nice find! That is bit embarrassing of a mistake that I made!
|
Looks like some unit test failiures, I can investigate tomorrow. Then we cut the Docker build! |
epugh
reviewed
Apr 16, 2021
config/initializers/devise.rb
Outdated
| @@ -14,7 +14,7 @@ | |||
| # Configure the e-mail address which will be shown in Devise::Mailer, | |||
| # note that it will be overwritten if you use your own mailer class | |||
| # with default "from" parameter. | |||
| config.mailer_sender = '[email protected]' | |||
| config.mailer_sender = ENV['EMAIL_SENDER'] | |||
There was a problem hiding this comment.
you followed the pattern of other ENV in this file, however I tend to put everything in customize_quepid.rb file as an attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Take the sender of the email from an environment variable. Fix the wrong variable name in the docker-compose.prod.yaml file for default scorer.
Motivation and Context
The mail sender is now hardcoded to
[email protected]. When you set up your own instance of Quepid, you should use your custom From email address.How Has This Been Tested?
Manually tested in the docker development environment
Types of changes
Checklist: