Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups for the invite user flow #339

Merged
merged 3 commits into from
May 10, 2021

Conversation

epugh
Copy link
Member

@epugh epugh commented May 10, 2021

Description

This fixes the admin user detail page which assumed that users had agreed to T&C, but that might not apply for invited users who haven't joined.

This also makes the logic aorund pending_invite in the front end better.

Motivation and Context

Now that we have the ability to invite someone, we're finding some places where assumpitons we made don't apply.

How Has This Been Tested?

manually and tests

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh requested a deployment to quepid-pr-339 May 10, 2021 17:16 Abandoned
@epugh epugh temporarily deployed to quepid-pr-339 May 10, 2021 17:18 Inactive
@epugh epugh merged commit d68f638 into master May 10, 2021
@epugh epugh deleted the let_admin_see_invited_users_who_havent_accepted branch January 8, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant