Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tryign to get M1 macs to work! #558

Merged
merged 19 commits into from
Sep 12, 2022
Merged

Tryign to get M1 macs to work! #558

merged 19 commits into from
Sep 12, 2022

Conversation

epugh
Copy link
Member

@epugh epugh commented Sep 9, 2022

Description

Motivation and Context

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh temporarily deployed to quepid-pr-558 September 9, 2022 21:52 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 9, 2022 22:13 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 10, 2022 12:53 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 11, 2022 14:26 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 11, 2022 16:43 Inactive
@epugh
Webpack is dead. Long live Javascript packaging!
cfe7d78 
We integrated webpacker as part of the Rails 6 upgrade, but never quite got it as the default workflow, continuing to use sprockets instead.  It ballooned our yarn.lock by 4x as well.   Let's rethink this when we migrate to Rails 7.
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 13:53 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 13:55 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 13:59 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 14:04 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 14:08 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 14:10 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 14:18 Inactive
@mkr
Remove installation of extra libraries, as the Chromium package will …
5db1838 
…install them, moving wget to "must have packages", inline the Node and Yarn RUNs
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 14:44 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 15:41 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 16:46 Inactive
@epugh epugh temporarily deployed to quepid-pr-558 September 12, 2022 17:18 Inactive
@epugh epugh merged commit 45370b2 into main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epugh @mkr