Import snapshot to current case #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
reviewed
May 16, 2023
epugh
reviewed
May 16, 2023
epugh
reviewed
May 16, 2023
| This operation WILL override your existing information needs. Proceed with caution! | ||
| </span> | ||
| <span ng-show="ctrl.snapshotsTypePicked()"> |
There was a problem hiding this comment.
so, do we override? or do we just create missing queries?
epugh
reviewed
May 16, 2023
| @@ -23,23 +24,32 @@ angular.module('QuepidApp') | |||
| size: 'lg', | |||
| resolve: { | |||
| theCase: function() { | |||
| return ctrl.acase; | |||
| return caseSvc.getSelectedCase(); //TODO not sure why this is needed for import snapshot to work? | |||
There was a problem hiding this comment.
let's see if this is STILL needed... or can we go back to return ctrl.acase
epugh
reviewed
May 16, 2023
| return ctrl.acase; | ||
| return caseSvc.getSelectedCase(); //TODO not sure why this is needed for import snapshot to work? | ||
| }, | ||
| querySnapshotSvc: function() { |
There was a problem hiding this comment.
Not positive, but because of dependency injection, I don't think you need htise... they are injected into the modal controller directly...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots or GIFs (if appropriate):
Types of changes
Checklist: