Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyboard shortcuts for a 0,1,2 custom scorer #752

Merged
merged 1 commit into from
Jun 8, 2023
Merged

add keyboard shortcuts for a 0,1,2 custom scorer #752

merged 1 commit into from
Jun 8, 2023

Conversation

depahelix2021
Copy link
Member

Description

Motivation and Context

Add javascript to enable keyboard shortcuts when a custom scorer is configured for 0,1,2.
I made it s,d,f instead of a,s,d.
#738

How Has This Been Tested?

Manually

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh linked an issue Jun 8, 2023 that may be closed by this pull request
@epugh epugh merged commit 7b5d410 into main Jun 8, 2023
@depahelix2021 depahelix2021 deleted the issue_738 branch June 12, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A three point custom scorer shoudl support keyboard shortcuts
2 participants