Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right escape value when creating the pagination searcher #87

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

jorgelbg
Copy link
Contributor

@jorgelbg jorgelbg commented May 6, 2020

When calling searcher.pager() for the Solr service the newly returned searcher was always using defaultSolrConfig as config options, ignoring the escapeQuery option.

Most of the time this is not an issue because queries are escaped by default. I hit this issue while using quepid with a query like field:(term), and the second batch of results would use the escaped query: field\:\(term\).

This causes that while the first page loads the desired results. If we navigate to the second page a potentially different result set would be returned.

@jorgelbg jorgelbg changed the title Use the right escaping strategy when creating the pagination searcher Use the right escape value when creating the pagination searcher May 8, 2020
@epugh epugh merged commit 9d34362 into o19s:master Jun 11, 2020
@epugh
Copy link
Member

epugh commented Jun 11, 2020

Rolling in Quepid 6.2 if you want to confirm the fix when I release it today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants