Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS2 Gem: do we need the message type field? #334

Closed
pawelbudziszewski opened this issue May 16, 2023 · 1 comment · Fixed by #434
Closed

ROS2 Gem: do we need the message type field? #334

pawelbudziszewski opened this issue May 16, 2023 · 1 comment · Fixed by #434
Assignees
@adamdbrw
Labels
feature/robotics This item is related to robotics. kind/bug Categorizes issue or PR as related to a bug. priority/minor Lowest priority. Work that may be scheduled sig/simulation Categorizes an issue or PR as relevant to SIG Simulation triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pawelbudziszewski
Copy link
Member

In components where ROS topics are defined, there is a field called Type. It seems, that this field (as well as TopicConfiguration.m_type) is never used or even checked. The user can provide virtually anything which doesn't influence the type of created topic.

Do we need this field?

Screenshot from 2023-05-16 16-43-43
@pawelbudziszewski pawelbudziszewski added the feature/robotics This item is related to robotics. label May 16, 2023
@byrcolin byrcolin added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation labels May 16, 2023
@lgleim lgleim added kind/bug Categorizes issue or PR as related to a bug. priority/minor Lowest priority. Work that may be scheduled triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 25, 2023
@lgleim
Copy link
Contributor

lgleim commented May 25, 2023

We just discussed this in today's issue triage and the field should probably just be removed, as it does not appear to be used by the code.

@adamdbrw adamdbrw self-assigned this Jun 12, 2023
@michalpelka michalpelka assigned ghost Jul 27, 2023
@ghost ghost mentioned this issue Jul 27, 2023
Merged
MateuszWasilewski pushed a commit to RobotecAI/o3de-extras that referenced this issue Oct 11, 2023
@michalpelka
Introduced MotorizedJointRequestBus (o3de#334)
3906100 
* Introduced `MotorizedJointRequestBus`

Signed-off-by: Michał Pełka <[email protected]>
MateuszWasilewski pushed a commit to RobotecAI/o3de-extras that referenced this issue Oct 11, 2023
@michalpelka
Fix formatting issue introduced in o3de#334 (o3de#335)
de87e37 
Signed-off-by: Michał Pełka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamdbrw adamdbrw

Labels
feature/robotics This item is related to robotics. kind/bug Categorizes issue or PR as related to a bug. priority/minor Lowest priority. Work that may be scheduled sig/simulation Categorizes an issue or PR as relevant to SIG Simulation triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the message type field in the ROS2 Sensor to read-only.
4 participants
@lgleim @adamdbrw @pawelbudziszewski @byrcolin