Conveyor belt component. #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpelka
force-pushed
the
mp/conveyor_belt
branch
2 times, most recently
from
ba6422b to
5bcdb26
Compare
michalpelka
force-pushed
the
mp/conveyor_belt
branch
from
2af4d45 to
7dd700f
Compare
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
adamdbrw
reviewed
Jun 29, 2023
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.h
Outdated
Show resolved
Hide resolved
michalpelka
force-pushed
the
mp/conveyor_belt
branch
2 times, most recently
from
7962a76 to
ee0364b
Compare
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.h
Outdated
Show resolved
Hide resolved
michalpelka
commented
Jul 5, 2023
|
I created a PR for this one: |
michalpelka
force-pushed
the
mp/conveyor_belt
branch
3 times, most recently
from
285cd7b to
513f104
Compare
michalpelka
force-pushed
the
mp/conveyor_belt
branch
from
513f104 to
5ef9b8d
Compare
adamdbrw
reviewed
Jul 11, 2023
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.h
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentKinematic.h
Outdated
Show resolved
Hide resolved
|
@adamdbrw thank you for the review. I agree with all your comments. Please check the revised contribution and my responses to comments. |
jhanca-robotecai
approved these changes
Jul 13, 2023
spham-amzn
reviewed
Jul 13, 2023
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponent.cpp
Outdated
Show resolved
Hide resolved
spham-amzn
reviewed
Jul 13, 2023
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponent.cpp
Outdated
Show resolved
Hide resolved
spham-amzn
reviewed
Jul 13, 2023
spham-amzn
reviewed
Jul 13, 2023
spham-amzn
reviewed
Jul 13, 2023
spham-amzn
reviewed
Jul 13, 2023
spham-amzn
reviewed
Jul 13, 2023
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponent.h
Outdated
Show resolved
Hide resolved
spham-amzn
reviewed
Jul 13, 2023
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponent.h
Outdated
Show resolved
Hide resolved
spham-amzn
reviewed
Jul 13, 2023
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentConfiguration.cpp
Outdated
Show resolved
Hide resolved
spham-amzn
reviewed
Jul 13, 2023
Gems/ROS2/Code/Source/FactorySimulation/ConveyorBeltComponentConfiguration.cpp
Outdated
Show resolved
Hide resolved
michalpelka
force-pushed
the
mp/conveyor_belt
branch
from
34bd9ef to
fb51351
Compare
move texture on conveyor belt mesh (#21) Add ConveyorBeltRequestBus (#24) Co-authored-by: Jan Hanca <[email protected]> Co-authored-by: Adam Dąbrowski <[email protected]> Co-authored-by: Steve Pham <[email protected]> Signed-off-by: Michał Pełka <[email protected]>
michalpelka
force-pushed
the
mp/conveyor_belt
branch
from
fb51351 to
984a371
Compare
|
Rebased on top of development and squashed commits. |
adamdbrw
approved these changes
Jul 24, 2023
pawelbudziszewski
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #364