Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot Importer: add sensor maker #503

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

jhanca-robotecai
Copy link
Contributor

This is the implementation of the hooks import in RobotImporter.

This PR will be extended with the registration of the hooks.

@jhanca-robotecai jhanca-robotecai changed the title Add gazebo sensor maker Add sensor maker Sep 12, 2023
@jhanca-robotecai jhanca-robotecai changed the title Add sensor maker Robot Importer: add sensor maker Sep 13, 2023
@jhanca-robotecai jhanca-robotecai marked this pull request as ready for review September 13, 2023 11:33
@jhanca-robotecai jhanca-robotecai requested review from a team as code owners September 13, 2023 11:33
@jhanca-robotecai
Copy link
Contributor Author

The code was tested with sample urdf file - a beer can with a camera. Please switch off Fix URDF to be compatible with libsdformat, as it crashes o3de with this particular data stored with the .urdf extension (it will be investigated separately).

<?xml version="1.0" ?>
<sdf version="1.5">
  <model name="beercan">
    <link name="link">
      <pose>0 0 0.115 0 0 0</pose>
      <inertial>
        <mass>0.390</mass>
        <inertia>
          <ixx>0.00058</ixx>
          <ixy>0</ixy>
          <ixz>0</ixz>
          <iyy>0.00058</iyy>
          <iyz>0</iyz>
          <izz>0.00019</izz>
        </inertia>
      </inertial>
      <collision name="collision">
        <geometry>
          <cylinder>
            <radius>0.055000</radius>
            <length>0.230000</length>
          </cylinder>
        </geometry>
      </collision>
      <visual name="visual">
        <geometry>
          <cylinder>
            <radius>0.055000</radius>
            <length>0.230000</length>
          </cylinder>
        </geometry>
      </visual>
      <sensor name="camera_test" type="camera">
        <pose>0 0 0 -1.57 -1.57 0</pose>
        <camera>
          <horizontal_fov>2.0</horizontal_fov>
          <image>
            <width>640</width>
            <height>480</height>
          </image>
          <clip>
            <near>0.05</near>
            <far>15000</far>
          </clip>
        </camera>
        <always_on>1</always_on>
        <update_rate>10</update_rate>
        <visualize>1</visualize>
      </sensor>
    </link>
  </model>
</sdf>

@jhanca-robotecai jhanca-robotecai force-pushed the jh/gazebo_sensor_maker branch 3 times, most recently from 56a4666 to d4725de Compare September 19, 2023 16:34
@michalpelka michalpelka merged commit 340b320 into o3de:development Sep 25, 2023
michalpelka pushed a commit to RobotecAI/o3de-extras that referenced this pull request Sep 25, 2023
* add SensorsMaker for SDFormat data
* publish hooks for processing
* revert output filename change
* code review: cache list of sensor hooks
---------
Signed-off-by: Jan Hanca <[email protected]>
michalpelka pushed a commit to RobotecAI/o3de-extras that referenced this pull request Sep 25, 2023
* add SensorsMaker for SDFormat data
* publish hooks for processing
* revert output filename change
* code review: cache list of sensor hooks
---------
Signed-off-by: Jan Hanca <[email protected]>
michalpelka pushed a commit to RobotecAI/o3de-extras that referenced this pull request Sep 25, 2023
* add SensorsMaker for SDFormat data
* publish hooks for processing
* revert output filename change
* code review: cache list of sensor hooks
---------
Signed-off-by: Jan Hanca <[email protected]>

Signed-off-by: Michał Pełka <[email protected]>
michalpelka pushed a commit to RobotecAI/o3de-extras that referenced this pull request Oct 2, 2023
* add SensorsMaker for SDFormat data
* publish hooks for processing
* revert output filename change
* code review: cache list of sensor hooks
---------
Signed-off-by: Jan Hanca <[email protected]>

Signed-off-by: Michał Pełka <[email protected]>
michalpelka pushed a commit that referenced this pull request Oct 3, 2023
* add SensorsMaker for SDFormat data
* publish hooks for processing
* revert output filename change
* code review: cache list of sensor hooks
---------
Signed-off-by: Jan Hanca <[email protected]>

Signed-off-by: Michał Pełka <[email protected]>
@jhanca-robotecai jhanca-robotecai deleted the jh/gazebo_sensor_maker branch November 7, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants