-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robot Importer: add sensor maker #503
Merged
michalpelka
merged 5 commits into
o3de:development
from
jhanca-robotecai:jh/gazebo_sensor_maker
Sep 25, 2023
Merged
Robot Importer: add sensor maker #503
michalpelka
merged 5 commits into
o3de:development
from
jhanca-robotecai:jh/gazebo_sensor_maker
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3e49a8
to
f540795
Compare
The code was tested with sample <?xml version="1.0" ?>
<sdf version="1.5">
<model name="beercan">
<link name="link">
<pose>0 0 0.115 0 0 0</pose>
<inertial>
<mass>0.390</mass>
<inertia>
<ixx>0.00058</ixx>
<ixy>0</ixy>
<ixz>0</ixz>
<iyy>0.00058</iyy>
<iyz>0</iyz>
<izz>0.00019</izz>
</inertia>
</inertial>
<collision name="collision">
<geometry>
<cylinder>
<radius>0.055000</radius>
<length>0.230000</length>
</cylinder>
</geometry>
</collision>
<visual name="visual">
<geometry>
<cylinder>
<radius>0.055000</radius>
<length>0.230000</length>
</cylinder>
</geometry>
</visual>
<sensor name="camera_test" type="camera">
<pose>0 0 0 -1.57 -1.57 0</pose>
<camera>
<horizontal_fov>2.0</horizontal_fov>
<image>
<width>640</width>
<height>480</height>
</image>
<clip>
<near>0.05</near>
<far>15000</far>
</clip>
</camera>
<always_on>1</always_on>
<update_rate>10</update_rate>
<visualize>1</visualize>
</sensor>
</link>
</model>
</sdf> |
michalpelka
reviewed
Sep 14, 2023
michalpelka
reviewed
Sep 14, 2023
adamdbrw
reviewed
Sep 14, 2023
Gems/ROS2/Code/Source/RobotImporter/ROS2RobotImporterEditorSystemComponent.cpp
Outdated
Show resolved
Hide resolved
lemonade-dm
reviewed
Sep 14, 2023
lemonade-dm
reviewed
Sep 14, 2023
Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
56a4666
to
d4725de
Compare
Signed-off-by: Jan Hanca <[email protected]>
d4725de
to
469a582
Compare
lemonade-dm
approved these changes
Sep 19, 2023
michalpelka
approved these changes
Sep 22, 2023
michalpelka
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
* add SensorsMaker for SDFormat data * publish hooks for processing * revert output filename change * code review: cache list of sensor hooks --------- Signed-off-by: Jan Hanca <[email protected]>
michalpelka
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
* add SensorsMaker for SDFormat data * publish hooks for processing * revert output filename change * code review: cache list of sensor hooks --------- Signed-off-by: Jan Hanca <[email protected]>
michalpelka
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
* add SensorsMaker for SDFormat data * publish hooks for processing * revert output filename change * code review: cache list of sensor hooks --------- Signed-off-by: Jan Hanca <[email protected]> Signed-off-by: Michał Pełka <[email protected]>
michalpelka
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Oct 2, 2023
* add SensorsMaker for SDFormat data * publish hooks for processing * revert output filename change * code review: cache list of sensor hooks --------- Signed-off-by: Jan Hanca <[email protected]> Signed-off-by: Michał Pełka <[email protected]>
michalpelka
pushed a commit
that referenced
this pull request
Oct 3, 2023
* add SensorsMaker for SDFormat data * publish hooks for processing * revert output filename change * code review: cache list of sensor hooks --------- Signed-off-by: Jan Hanca <[email protected]> Signed-off-by: Michał Pełka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the hooks import in RobotImporter.
This PR will be extended with the registration of the hooks.