chore: Avoid accidental rendering

oBusk · Oct 31, 2022 · 977b1d0 · 977b1d0 · vercel · Oct 31, 2022
1 parent 05136c3
commit 977b1d0
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 11 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -32,6 +32,7 @@
                 "warnOnUnassignedImports": true
             }
         ],
+        "react/jsx-no-leaked-render": "error",
         "sort-imports": [
             "error",
             { "ignoreCase": true, "ignoreDeclarationSort": true }

diff --git a/src/components/Diff/DiffFile/DiffPlaceholder.tsx b/src/components/Diff/DiffFile/DiffPlaceholder.tsx
@@ -16,7 +16,7 @@ const DiffPlaceholder = forwardRef<DiffPlaceholderProps, "div">(
             <Button variant="ghost" colorScheme="blue">
                 Load Diff
             </Button>
-            {reason && <span>{reason}</span>}
+            {reason ? <span>{reason}</span> : null}
         </Stack>
     ),
 );

diff --git a/src/components/DiffIntro/DiffIntro.tsx b/src/components/DiffIntro/DiffIntro.tsx
@@ -98,7 +98,7 @@ const DiffIntro = forwardRef<DiffIntroProps, "h2">(
                         }
                     />
                 </Heading>
-                {packagephobiaResults && (
+                {packagephobiaResults ? (
                     <>
                         <Heading marginTop="8px" size="xs">
                             {Packagephobia.name}
@@ -142,8 +142,8 @@ const DiffIntro = forwardRef<DiffIntroProps, "h2">(
                             width="100%"
                         />
                     </>
-                )}
-                {bundlephobiaResults && (
+                ) : null}
+                {bundlephobiaResults ? (
                     <>
                         <Heading size="xs">{Bundlephobia.name}</Heading>
                         <BundlephobiaFlags data={bundlephobiaResults} />
@@ -185,7 +185,7 @@ const DiffIntro = forwardRef<DiffIntroProps, "h2">(
                             width="100%"
                         />
                     </>
-                )}
+                ) : null}
                 <Heading size="l">npm diff</Heading>
                 <Options options={options} />
                 {/* <Command

diff --git a/src/components/DiffIntro/Options.tsx b/src/components/DiffIntro/Options.tsx
@@ -18,12 +18,12 @@ const Options = forwardRef<OptionsProps, typeof BorderBox>(
                 <Heading size="xs" marginBottom="1em">
                     Options
                 </Heading>
-                {diffFiles && (
+                {diffFiles ? (
                     <Text>
                         <b>files:</b>{" "}
                         <Code>{diffFiles.join(" ") || "\u00A0"}</Code>
                     </Text>
-                )}
+                ) : null}
                 {specifiedOptions.map(([key, value]) => (
                     <Text key={key}>
                         <b>{key}:</b> <Code>{JSON.stringify(value)}</Code>

diff --git a/src/components/Landing/MainForm/SpecInput/Suggestion/Suggestion.tsx b/src/components/Landing/MainForm/SpecInput/Suggestion/Suggestion.tsx
@@ -16,7 +16,7 @@ const Suggestion: FunctionComponent<SuggestionProps> = ({
         <>
             <Title name={name} version={version} />
 
-            {body && <Text fontSize="xs">{body}</Text>}
+            {body ? <Text fontSize="xs">{body}</Text> : null}
             <HStack marginTop="4px">
                 {tags.map((tag) => (
                     <VersionTag key={tag} value={tag} />

diff --git a/src/components/theme/ButtonExpandBox.tsx b/src/components/theme/ButtonExpandBox.tsx
@@ -33,9 +33,9 @@ const ButtonExpandBox = forwardRef<ButtonExpandBoxProps, "div">(
                 {...props}
                 ref={ref}
             >
-                {isExpanded && (
+                {isExpanded ? (
                     <BorderBox overflow="auto">{children}</BorderBox>
-                )}
+                ) : null}
 
                 <Tooltip label={buttonLabel}>
                     <Button

diff --git a/src/components/theme/CollapsableBorderBox/CollapsableBorderBox.tsx b/src/components/theme/CollapsableBorderBox/CollapsableBorderBox.tsx
@@ -21,7 +21,7 @@ const CollapsableBorderBox = forwardRef<CollapsableBorderBoxProps, "div">(
                 >
                     {header}
                 </CollapsableBorderBoxHeader>
-                {isExpanded && <Box overflow="auto">{children}</Box>}
+                {isExpanded ? <Box overflow="auto">{children}</Box> : null}
             </BorderBox>
         );
     },