ui: User portal and Grafana tests in a separate Selenium session #280
Conversation
tinez
commented
Sep 28, 2022
tinez
commented
- selenium: Remove unused 'selenium_version' fixture
- selenium: Move fixtures to fixtures.selenium for reuse
- ui: Move some fixtures to 'fixtures.ui' module
- ui: Remove unused imports and objects
- ui: Separate user portal and grafana tests from other UI tests
|
/ost |
|
Right, so in the latest run |
tinez
force-pushed
the
user-portal-in-separate-selenium-session
branch
from
a2e4f90 to
180ed76
Compare
|
/ost |
| welcome_screen.wait_for_user_logged_out() | ||
| assert welcome_screen.is_user_logged_out() | ||
|
|
||
| if keycloak_enabled: |
There was a problem hiding this comment.
I think we should still keep this test and assert for non-keycloak authentication.
There was a problem hiding this comment.
I think I actually implemented it the way you suggested - it's still running for non-keycloak envs. The diff is big so please have a second look.
There was a problem hiding this comment.
yes, I can see it now, sorry about that.
|
I don't know...so what does this actually solve and how? |
Signed-off-by: Marcin Sobczyk <[email protected]>
In an effort to reuse them in a new test module, we're moving some of the fixtures to 'pytest.fixtures.selenium' module. Signed-off-by: Marcin Sobczyk <[email protected]>
In an effort to reuse them in a new test module, we're movinvg some of the fixtures to 'pytest.fixtures.ui' module. Signed-off-by: Marcin Sobczyk <[email protected]>
Signed-off-by: Marcin Sobczyk <[email protected]>
Due to the problem with keycloak logout we're using a separate Selenium session to test user portal and grafana. Signed-off-by: Marcin Sobczyk <[email protected]>
The new name reflects the purpose of the tests better now. Signed-off-by: Marcin Sobczyk <[email protected]>
tinez
force-pushed
the
user-portal-in-separate-selenium-session
branch
from
180ed76 to
0db0452
Compare
It solves the problem of user portal tests failing. We're simply running a completely new Selenium setup for user portal and Grafana tests. The gist of the PR is changing |
|
and what is it going to help with? IIUC it won't necessarily affect the logout/keycloak problem |
