Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated jquery, patternfly, patternfly-react, handlebars and html-loader #1047

Merged
merged 1 commit into from
Jul 8, 2019
Merged

updated jquery, patternfly, patternfly-react, handlebars and html-loader #1047

merged 1 commit into from
Jul 8, 2019

Conversation

thaorell
Copy link
Contributor

Updating dependencies with high and moderate severity.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1694032

@thaorell thaorell added the Flag: Bugzilla Issue or PR tracked on Bugzilla as well. use 'tracking_only' if there is no web-ui work to do label Jun 21, 2019
@thaorell thaorell requested review from sjd78 and bond95 June 21, 2019 15:27
@sjd78
Copy link
Member

sjd78 commented Jun 21, 2019

ci add to whitelist

@sjd78
Copy link
Member

sjd78 commented Jun 25, 2019

ci test please

sjd78
sjd78 reviewed Jun 25, 2019
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency changes look ok, and with a pre-seed on ovirt-engine-nodejs-modules, it passes CI.

Does bootstrap need to be updated to 3.4.1 and which version does patternfly 3.59.1 references?

@thaorell
Copy link
Contributor Author

Bootstrap ~3.4.0 is required for patternfly, also patternfly 3.59.2 was released recently

@thaorell thaorell self-assigned this Jun 26, 2019
sjd78
sjd78 approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the update locally and it all looks good.

@oVirt oVirt deleted a comment from ovirt-infra Jun 27, 2019
@thaorell thaorell force-pushed the update_dependencies branch from 445926a to b7eca7a Compare June 27, 2019 19:45
@sjd78 sjd78 added the Status: ON_QA status ON_QA (currently being tested) label Jul 2, 2019
@michalskrivanek
Copy link
Member

let's merge it then to see if they are all that's needed....

@michalskrivanek michalskrivanek merged commit 09eaefc into oVirt:master Jul 8, 2019
gerrit-ovirt-org pushed a commit to oVirt/ovirt-engine-nodejs-modules that referenced this pull request Nov 4, 2021
@sjd78
Add pre-seed for two projects, remove old pre-seeds
03de60d 
  - remove pre-seeds from 2018
  - pre-seed for:
    - ovirt-web-ui 2019-06-24 (oVirt/ovirt-web-ui#1048)
    - ovirt-web-ui 2019-06-25 (oVirt/ovirt-web-ui#1047)
    - ovirt-engine-ui-extensions (https://gerrit.ovirt.org/101012)

Change-Id: I360ef83f6e9ca8d7d2c7196b63644628bebd5d77
Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 sjd78 approved these changes

@bond95 bond95 Awaiting requested review from bond95

Assignees

@thaorell thaorell

Labels
Flag: Bugzilla Issue or PR tracked on Bugzilla as well. use 'tracking_only' if there is no web-ui work to do Status: ON_QA status ON_QA (currently being tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaorell @sjd78 @michalskrivanek