feat: do not trust front end message history #570
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
| // NOTE: this lesson plan is used by the chat endpoint | ||
| lessonPlan, |
There was a problem hiding this comment.
Can we delete line 49 above now? const lessonPlan = useLessonPlanStore((state) => state.lessonPlan);
| lessonPlan = parsedOutput.lessonPlan as LooseLessonPlan; | ||
| } | ||
| } catch (error) { | ||
| log.error(`Error parsing output for chat ${chatId}`, error); |
There was a problem hiding this comment.
I just want to confirm that we don't want to report to sentry here
There was a problem hiding this comment.
Thanks - I've added Sentry reporting. For now, no additional error handling for the front end though
| ); | ||
| return { messages, lessonPlan }; | ||
| } catch (error) { | ||
| log.error(`Error loading chat data for chat ${chatId}`, error); |
There was a problem hiding this comment.
Again here, just want to confirm that we don't want to report to sentry
| aila = await createAilaInstance({ | ||
| config, | ||
| options, | ||
| chatId, | ||
| userId, | ||
| messages, | ||
| lessonPlan: dbLessonPlan, | ||
| llmService, | ||
| moderationAiClient, | ||
| threatDetectors, | ||
| }); |
|
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
To test: