Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initial state being called twice #574

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix: initial state being called twice #574

merged 1 commit into from
Mar 3, 2025

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Mar 3, 2025

Description

  • await this._chat.handleSettingInitialState(); was being called twice in the stream handler

@vercel Vercel
Copy link

vercel bot commented Mar 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 2:31pm

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Playwright test results

passed  17 passed
skipped  2 skipped

Details

report  Open report ↗︎
stats  19 tests across 16 suites
duration  2 minutes, 40 seconds
commit  cbc2146

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI
No persona › tests/chat-performance.test.ts › Component renders during lesson chat › There are no unnecessary rerenders across left and right side of chat

@stefl stefl merged commit f61bc92 into main Mar 3, 2025
18 checks passed
@stefl stefl deleted the fix/initial_state_dupe branch March 3, 2025 14:48
@mikeritson-oak mikeritson-oak mentioned this pull request Mar 6, 2025
Merged
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext