Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: continue migrating Aila package to support variable documents #575

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Mar 3, 2025

Description

  • This continues the process of moving to AilaDocument instead of AilaLessonPlan
  • Still no migrations - just changing some variable and class names

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 6:11pm

return {
useRag: options?.useRag ?? true,
temperature: options?.temperature ?? DEFAULT_TEMPERATURE,
// #TODO we should find a way to make this less specifically tied
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses this TODO

Copy link

sonarqubecloud bot commented Mar 3, 2025

@@ -50,10 +50,6 @@ export class AilaDocument implements AilaDocumentService {
this._content = content;
}

public setContent(content: AilaDocumentContent) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes this method in preference of set above

@@ -6,6 +6,10 @@ export type AilaDummyDocumentContent = {
keyStage: string;
topic?: string;
body: string;
basedOn?: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, all document types would need a basedOn attribute

Copy link

github-actions bot commented Mar 3, 2025

Playwright test results

passed  16 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  19 tests across 16 suites
duration  3 minutes
commit  86e1811

Flaky tests

No persona › tests/aila-chat/rate-limiting.test.ts › User is restricted after message rate limit is reached

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI
No persona › tests/chat-performance.test.ts › Component renders during lesson chat › There are no unnecessary rerenders across left and right side of chat

@stefl stefl changed the title feat: continue migrating Aila package to support variable documents (WIP) feat: continue migrating Aila package to support variable documents Mar 4, 2025
@stefl stefl requested a review from a team March 4, 2025 09:40
@stefl stefl merged commit 0c25081 into main Mar 4, 2025
23 checks passed
@stefl stefl deleted the feat/aila_lesson_doc branch March 4, 2025 14:33
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants