Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pupil 1221/oak link card #390

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BTitterington
Copy link
Contributor

@BTitterington BTitterington commented Mar 6, 2025

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Ticket here

This PR adds a new component called OakLinkCard

In addition it also

  • Adds the Finance subject icon token
  • Updates OakPromoTag to include a background on the text span. This was raised as a contrast issue in the storybook accessibility tab.

Link to the design doc

https://www.figma.com/design/YcWQMMhHPVVmc47cHHEEAl/Oak-Design-Kit?node-id=14029-2178&t=TxpTNklFgvHEkpc1-0

A link to the component in the deployment preview

https://deploy-preview-390--lively-meringue-8ebd43.netlify.app/?path=/docs/components-molecules-oaklinkcard--docs

Testing instructions

Check that prop changes has the desired effect.

ACs

  • Card is clickable
  • Card content is configurable (shown in different stories)
  • Add new ‘finance’ subject icon (shown in default story)
  • Accessibility
  • Test coverage
  • Storybook documentation

Copy link

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 392264b
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/67c9c7cbb2fdab0008cad948
😎 Deploy Preview https://deploy-preview-390--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BTitterington BTitterington marked this pull request as ready for review March 6, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants