Skip to content

Commit

Permalink
[RHELC-857] Remove Centos6 from testing (#698)
Browse files Browse the repository at this point in the history
  • Loading branch information
hosekadam authored Jan 11, 2023
1 parent 0baba7c commit 62a3981
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 132 deletions.
18 changes: 12 additions & 6 deletions .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,24 @@
"extends": [
"config:base"
],
"enabledManagers": ["dockerfile", "pip_requirements", "github-actions"],
"enabledManagers": [
"dockerfile",
"pip_requirements",
"github-actions"
],
"ignorePaths": [
"**/centos6.Dockerfile",
"**/centos7.Dockerfile",
"**/rpmbuild.centos7.Dockerfile",
"**/centos6*.requirements.txt"
],
"packageRules": [
{
"matchPackageNames": ["pytest"],
"matchFiles": ["requirements/centos8.requirements.txt"],
"matchPackageNames": [
"pytest"
],
"matchFiles": [
"requirements/centos8.requirements.txt"
],
"allowedVersions": "<=7.0"
}
]
}
}
2 changes: 1 addition & 1 deletion .github/workflows/build_images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: build-centos${{ matrix.centos_ver }}
strategy:
matrix:
centos_ver: [6, 7, 8]
centos_ver: [7, 8]

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: coverage-centos${{ matrix.centos_ver }}
strategy:
matrix:
centos_ver: [6, 7, 8]
centos_ver: [7, 8]

runs-on: ubuntu-20.04
steps:
Expand Down
24 changes: 0 additions & 24 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,6 @@ on:
types: [published]

jobs:
build_el6_rpm:
name: Build EL6 RPM
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Build RPM package for EL6
id: rpm_build_el6
uses: bocekm/rpmbuild@el6
with:
spec_path: "packaging/convert2rhel.spec"

- name: Upload EL6 RPM as release asset
id: upload_release_asset_el6
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ github.event.release.upload_url }}
asset_path: ${{ steps.rpm_build_el6.outputs.rpm_path }}
asset_name: ${{ steps.rpm_build_el6.outputs.rpm_name }}
asset_content_type: ${{ steps.rpm_build_el6.outputs.content_type }}

build_el7_rpm:
name: Build EL7 RPM
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
centos_ver: [6, 7, 8]
centos_ver: [7, 8]

runs-on: ubuntu-20.04
steps:
Expand Down
44 changes: 0 additions & 44 deletions Dockerfiles/centos6.Dockerfile

This file was deleted.

12 changes: 1 addition & 11 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,12 @@ endif
@echo "or login first with '$(DOCKER) login ghcr.io -u $$github_username'"
@echo "https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry"
@echo
@echo "Pulling $(IMAGE)-centos6"
@$(DOCKER) pull $(IMAGE)-centos6
@echo "Pulling $(IMAGE)-centos7"
@$(DOCKER) pull $(IMAGE)-centos7
@echo "Pulling $(IMAGE)-centos8"
@$(DOCKER) pull $(IMAGE)-centos8
.build-images:
@echo "Building images"
@$(DOCKER) build -f Dockerfiles/centos6.Dockerfile -t $(IMAGE)-centos6 .
@$(DOCKER) build -f Dockerfiles/centos7.Dockerfile -t $(IMAGE)-centos7 .
@$(DOCKER) build -f Dockerfiles/centos8.Dockerfile -t $(IMAGE)-centos8 .
touch $@
Expand All @@ -115,19 +112,12 @@ lint: images
lint-errors: images
@$(DOCKER) run $(DOCKER_RM_CONTAINER) -v $(shell pwd):/data:Z $(IMAGE)-centos8 bash -c "scripts/run_lint.sh --errors-only"

tests: tests6 tests7 tests8
tests: tests7 tests8

# These files need to be made writable for pytest to run
WRITABLE_FILES=. .coverage coverage.xml
DOCKER_TEST_FUNC=echo $(DOCKER_TEST_WARNING) ; $(DOCKER) run -v $(shell pwd):/data:Z --name pytest-container -u root:root $(DOCKER_RM_CONTAINER) $(IMAGE)-$(1) /bin/sh -c 'touch $(WRITABLE_FILES) ; chown app:app $(WRITABLE_FILES) ; su app -c "pytest $(2) $(PYTEST_ARGS)"' ; DOCKER_RETURN=$${?} ; $(DOCKER_CLEANUP) ; exit $${DOCKER_RETURN}

tests6: images
@echo 'CentOS Linux 6 tests'
ifneq ("$(SHOW_CAPTURE)", "no")
@$(call DOCKER_TEST_FUNC,centos6,--show-capture=$(SHOW_CAPTURE))
else
@$(call DOCKER_TEST_FUNC,centos6,)
endif

tests7: images
@echo 'CentOS Linux 7 tests'
Expand Down
8 changes: 0 additions & 8 deletions requirements/centos6.requirements.txt

This file was deleted.

8 changes: 0 additions & 8 deletions requirements/centos6_pre.requirements.txt

This file was deleted.

28 changes: 0 additions & 28 deletions scripts/centos6_pip_prep.sh

This file was deleted.

0 comments on commit 62a3981

Please sign in to comment.